[typing] Added types to adapter.ts #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is really easy to merge and it is manageable |
foxriver76
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- schemas/iobroker.json: Language not supported
|
#3001 as there seem to be some inconsistencies with maxQueue, it only affects states DB (used by adapter.ts) not other DBs, hence I removed the dead code to clean this up and move it correctly to states DB only + fix the initial iobroker.json. Just mergeinto your branch if it is fine for you. |
Generally yes but checking in depth then brings up things like now and 1.5 hours go into the land ;-) |
* maxQueue only has effects for states db in adapter.ts - so remove this dead code from dbs - cleanup the loglevel handling * fix typo * cleanup imports * casing fixed again * build schema
foxriver76
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some typing to adapter.ts
mostly for 'adapter.systemConfig' (I thought that it is content of 'systetm.config' object)
Tests